rubyonrailsin

I'm definitely down with refactoring if people think it will be easier
to understand. Does someone want to create an LH ticket and submit a
patch? If you improve checkout please make sure that the hook
functionality for steps (see detailed online docs) is maintained as
well. I do think its still useful to allow people to hook into a
before and after in the update and edit cases. We can just simplify
by not overwriting 50% of r_c in this case.

Sean Schofield

-------------------------------------------
Rails Dog LLC
2 Wisconsin Circle, Suite 700
Chevy Chase, MD 20815
voice: (301)560-2000
-------------------------------------------

On Wed, Mar 24, 2010 at 11:52 AM, Michael Guterl <mguterl@gmail.com> wrote:
> CheckoutsController is the one that stands out to me, OrdersController
> isn't as "bad."
>
> Best,
> Michael Guterl
>
> On Wed, Mar 24, 2010 at 1:03 AM, Sarah Mei <sarahmei@gmail.com> wrote:
>> orders_controller and checkouts_controller are the two I'd target.
>> They're the heart of the application, so it's worth being very
>> explicit about what's happening. Plus since checkouts don't really fit
>> REST, you could do something more natural and end up with a much
>> skinnier controller. win-win!
>>
>> On Tue, Mar 23, 2010 at 7:45 PM, Sean Schofield <sean@railsdog.com> wrote:
>>> So which controllers would we like to see move away from r_c?  I still
>>> think checkout should have its own r_c like hooks for the checkout
>>> steps.  But we could implement that without making that specific
>>> controller and r_c controller.
>>
>> --
>> You received this message because you are subscribed to the Google Groups "Spree" group.
>> To post to this group, send email to spree-user@googlegroups.com.
>> To unsubscribe from this group, send email to spree-user+unsubscribe@googlegroups.com.
>> For more options, visit this group at http://groups.google.com/group/spree-user?hl=en.
>>
>>
>
> --
> You received this message because you are subscribed to the Google Groups "Spree" group.
> To post to this group, send email to spree-user@googlegroups.com.
> To unsubscribe from this group, send email to spree-user+unsubscribe@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/spree-user?hl=en.
>
>

--
You received this message because you are subscribed to the Google Groups "Spree" group.
To post to this group, send email to spree-user@googlegroups.com.
To unsubscribe from this group, send email to spree-user+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/spree-user?hl=en.